test-web: Capture all process output#8877
Merged
shannonbooth merged 6 commits intoLadybirdBrowser:masterfrom Apr 15, 2026
Merged
test-web: Capture all process output#8877shannonbooth merged 6 commits intoLadybirdBrowser:masterfrom
shannonbooth merged 6 commits intoLadybirdBrowser:masterfrom
Conversation
jonbgamble
force-pushed
the
pr-test-web
branch
2 times, most recently
from
ab060fc to
db69322
Compare
github-actions
bot
added
the
conflicts
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
github-actions
bot
removed
the
conflicts
|
|
||
| void ProcessManager::add_process(WebView::Process&& process) | ||
| { | ||
| Threading::MutexLocker locker { m_lock }; |
Member
There was a problem hiding this comment.
This mutex seems dubious beforehand as well considering it does not protect find_process properly, but it does not seem correct to remove the mutex here
Contributor
Author
There was a problem hiding this comment.
HashMap owns the Process object lifetimes, and find_process() returns a borrowed reference into that storage. We can't guarantee its lifetime to another thread.
I would just replace the misleading mutex and locks with event loop thread-affinity asserts, and revisit the design if non-event-loop callers are ever needed.
It's almost 100% useless in practice and not worth the noise.
Use files instead of buffers. Consolidate stderr and stdout into one view. Break handling out into TestRunCapture and CaptureFile helper classes. We will use them to log output from ALL processes in the next commit.
Add on_process_added callback so test-web can set up captures
This prevents glitches where stale test status lines can bleed above the live display list. Log this additional captured output so it can be reviewed if a main or helper process failure is suspected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.